Re: [PATCH] Fixes testsuit/gdb.base/annota1.exp

[Paul Gilliam <pgilliam at us dot ibm dot com>]

On Wednesday 27 April 2005 08:47, Daniel Jacobowitz wrote:
> On Fri, Apr 15, 2005 at 03:37:55PM -0800, Paul Gilliam wrote:
> > OK. ?this is in partial responce to:
> > ????????http://sourceware.org/ml/gdb-patches/2005-04/msg00145.html
> > 
> > There were two problems with gdb.base/annota1.exp.  This patch is only for the second one.
> > 
> > The problem here is that a bug in backtrace was causing a false nagitive in gdb.base/annota1.exp,
> > so the feature being tested was OK, but was being failed due to some other bug that caused the
> > backtrace to not stop at the end.
> > 
> > NOTE: this also allows for 'doc symbols' like '.printf'.  I understand that these are going away
> > soon, but an extra '\.?' shouldn't hurt anything.
> > 
> > -=# Paul #=-
> > 
> > --
> > 2005-04-15  Paul Gilliam  <pgilliam@us.ibm.com>
> > 
> > 	* gdb.base/annota1.exp: Deal with backtrace 'skidding' past
> > 	top-of-stack due to a bug unrealted to annotation.
> 
> I would strongly prefer not to include this one.  This isn't a unit
> testsuite; all GDB tests cover multiple features.  Some backtrace bugs
> only show up in these testcases, because they're so picky.

OK, I understand.

I withdraw this patch.

> 
> You didn't mention when resubmitting these patches that there were
> objections to them.  That's kind of important.  I see that Andrew had
> the same objection that I do.
> 

Opps, Sorry.  I'll be more carefull next time