This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] recgonize SGI compiler in testsuite/lib/gdb.exp
On Fri, Apr 15, 2005 at 02:40:33PM -0800, Paul Gilliam wrote:
> On Thursday 14 April 2005 12:36, Daniel Jacobowitz wrote:
> > On Fri, Apr 08, 2005 at 01:06:13PM -0800, Paul Gilliam wrote:
> > > This patch updates compiler.c and compiler.cc in testsuit/lib so
> > > that get_compiler_info will deal with the SGI compiler.
> > >
> > > I don't have access to an SGI system, so this is un-tested: I
> > > gleaned the info from on-line manuals.
It's better than nothing; the patch is OK in principle. Please correct
some formatting nits for me.
> 2005-04-09 Paul Gilliam <pgilliam@us.ibm.com>
>
> * lib/compiler.c: Detect SGI compiler and it's version.
> * lib/compiler.cc:Likewise.
"its", not "it's". Space before "Likewise".
> + #if defined (__sgi)
> + /* The sgi compiler defines _COMPILER_VERSION as xyz for version x.y.z */
> + set compile_info "sgi-[join [split _COMPILER_VERSION {}] -]"
> + #endif
"SGI" instead of "sgi". "x.y.z. */" instead of "x.y.z */". I realize
the rest of the file is sloppy about that.
I sure hope that no one else gets the bright idea to use the generic
name _COMPILER_VERSION.
--
Daniel Jacobowitz
CodeSourcery, LLC