Re: PATCH: Support Windows in event-loop.c

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

   Date: Mon, 25 Apr 2005 15:08:46 -0700
   From: Mark Mitchell <mark@codesourcery.com>

   Mark Kettenis wrote:

   >    Thanks, committed.
   > 
   > Thanks!  That was the last patch, isn't it?  If so, can you add some
   > blurp to NEWS about it?

   Not *quite* the last patch.  There are still readline changes required. 
     By and large, I should think these will be rather less controversial; 
   most of them are just using autoconf macros to avoid using stuff that 
   Windows doesn't have.  There is also one patch that basically says 
   "don't use any of that termcap stuff" -- but that's really just a 
   Makefile patch not to link in one file under Windows.

   I understand that the readline used by GDB contains some GDB-local 
   patches.  So, I'm planning to submit my patches to this list, too.  I 
   know that normally we'd want to go to the upstream source, but Daniel 
   says that's probably not practical in this case.

   So, is it OK to submit readline patches here?

I'd say, please make an effort to get them into the official readline
first.  While we have some local readline patches, we should really
try to keep the number of them to the minimum.  Every local patch
makes merging the next version of readline more difficult :-(.  Once
the stuff is accepted upstream, no one should stop you from importing
those changes into GDB's readline.

If that really is not practical, try to keep the impact on existing
files as minimal as possible.  Try to keep things localized,
preferably in a seperate source files.  That will make life much
easier for us in the future.

Mark