This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: SH simulator build fix
On Tue, Apr 12, 2005 at 10:50:08PM +0100, Jonathan Larmour wrote:
> Daniel Jacobowitz wrote:
> >On Tue, Apr 12, 2005 at 08:04:54PM +0100, Jonathan Larmour wrote:
> >
> >>The SH simulator doesn't build on slightly older GCC. gencode.c relies on
> >>the C99 ability (like C++) to define variables after code in a function.
> >>So for example it would generate source code in code.c like:
> >>
> >> case 37:
> >> {
> >> {
> >> RAISE_EXCEPTION_IF_IN_DELAY_SLOT ();
> >> int i;
> >>
> >>where RAISE_EXCEPTION_IF_IN_DELAY_SLOT is:
> >>#define RAISE_EXCEPTION_IF_IN_DELAY_SLOT() \
> >> if (in_delay_slot) RAISE_EXCEPTION (SIGILL)
> >>
> >>
> >>Fortunately the fix is trivial, and attached!
> >>
> >>2005-04-12 Jonathan Larmour <jifl@eCosCentric.com>
> >>
> >> * gencode.c (tab): Avoid inserting code before variables all
> >> declared.
> >>
> >>I have CVS write access to src, so I can do the check-in assuming that's
> >>easier.
> >
> >
> >Sure looks like an obvious fix to me; please go ahead, assuming that
> >you have tested the resulting simulator.
>
> For a build failure?
>
> I'm not in a position to test the simulator sorry. I don't have tools that
> can generate code that can run in it. To be honest, the build failure was
> only affecting me by getting in the way of a GDB build.
Well, the patch does look correct after a closer reading, and the
resulting simulator builds where the old one didn't. Please go ahead
and check this in.
--
Daniel Jacobowitz
CodeSourcery, LLC