Re: MI testsuite improvements

[Andrew Cagney <cagney at gnu dot org>]

Bob Rossi wrote:
> On Thu, Feb 10, 2005 at 03:52:08PM -0500, Andrew Cagney wrote:
>
> > > OO, I see, are you saying the mi-* tests will become the new ones, and
> > > the mi2-* are frozen for the mi2-* development cycle?
> > >
> > > In order to do this for only the new tests, I'll have to add a new
> > > parameter to mi_gdb_start to tell it to either open or not open a pty 
> > > for the inferior. Hope this will be OK.
> >
> > M'kay.

I've thought hard about this one.  I'm ok with the theory in that we 
should have a test of GDB against a "pipe" (i.e., something that doesn't 
echo).  I've reservations about applying it across all tests though.

At present you can look at the log and see the exact interaction as 
you'll get when you run that same GDB in a normal terminal.  This change 
alters that.

Can you post an example log so that we can see what it looks like.

Andrew

> Here is the patch that give's the inferior it's own PTY and only changes 
> the mi-* testcase's and not the the mi2-* testcases. Just to mention, it
> will definatly be more complicated to have only the mi-* testcase's use
> the PTY and have the mi2-* not. However, if this is what you want, it is
> possible to do.
>
> Few things to note is that 
>    - mi_gdb_start now takes an optional parameter. This tells it to have
>      the inferior use a tty or not. I could make this parameter not
>      optional, and put 'false' everywhere for the mi2-* tests. Is this
>      what you want? Sorry, don't know what normal conventions are for
>      Tcl programming, since I'm a newbie.
>    - mi_gdb_test now takes an IPATTERN parameter, which refer's to the
>      pattern the inferior must match if the parameter is present. A
>      PASS is given if the output is matched, otherwise a FAIL. So, when
>      calling mi_gdb_test, when you give the IPATTERN, 2 PASS's are given
>      instead of just 1.