This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [gdbserver/patch] Z packet support
- From: Paul Schlie <schlie at comcast dot net>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: Orjan Friberg <orjan dot friberg at axis dot com>,<gdb-patches at sources dot redhat dot com>
- Date: Sun, 30 Jan 2005 10:57:17 -0500
- Subject: Re: [gdbserver/patch] Z packet support
> From: Daniel Jacobowitz <drow@false.org>
> If you want to make cosmetic structural changes to gdbserver, and
> can show that they actually have benefit, then feel free to file a
> copyright assignment and submit patches yourself.
>
> As it happens:
> 1. I don't care either way.
- understood.
> 2. Please re-read the comment; it should not be void *. It is also
> required that it be harmless for CORE_ADDR to be too large; see
> MIPS n32 vs n64.
[ Regarding: And while at it, move CORE_ADDR tweak server.h to wherever
it likely belongs? (and/or redefine it to void* if more appropriate)? ]
- sorry, it simply seemed implied by your own comment on the subject:
"CORE_ADDR is always a long long in gdbserver, so your sizeof (addr)
probably doesn't work right for 32-bit targets. I guess sizeof
(void *) is always right for this, though... at least for the kinds
of targets gdbserver supports now."
combined with it's own FIXME comment:
/* FIXME: This should probably be autoconf'd for. It's an integer type
at least the size of a (void *). */
typedef long long CORE_ADDR;
> 3. There are nowhere near enough exported functions to justify
> proliferating headers.
- sorry, guess I always considered "proliferating headers" as required
a superior alternative to the maintenance problems which proliferating
redundant declarations otherwise creates.
> --
> Daniel Jacobowitz