This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/pa-risc] Correct incorrect frame base
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 1 Jan 2005 16:31:02 +0400
- Subject: Re: [RFA/pa-risc] Correct incorrect frame base
- References: <20041231151415.GL1824@adacore.com> <20041231161258.GA4437@nevyn.them.org>
> On Fri, Dec 31, 2004 at 07:14:15PM +0400, Joel Brobecker wrote:
> > There is a small confusion in the source register for the addil
> > instruction. The actual sequence should be
> >
> > addil high21,%r30
> > ldo low11(%r1),%r30
> >
> > I think the confusion comes from the fact that the result of
> > the sum is stored in %r1.
>
> "addil <number>,%r30" sets %r1 and not %r30?
Yes. "addil high21,%rn" adds high21 to register n, and then always
stores the results in r1.
> Whose bright idea was that, anyway?
:-)
> > 2004-12-31 Joel Brobecker <brobecker@gnat.com>
> >
> > * hppa-tdep.c (prologue_inst_adjust_sp): Fix small confusion
> > in register number for ldil instruction.
> >
> > Tested on HP/UX 11.00, no regression.
> > OK to apply?
>
> OK. Typo in the changelog: that's addil, not ldil, isn't it?
Good catch, sorry for the confusion. Fixed and checked in.
Thank you!
--
Joel