This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: Modified Watchthreads Patch
- From: Daniel Jacobowitz <drow at false dot org>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Jeff Johnston <jjohnstn at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Fri, 10 Dec 2004 08:31:16 -0500
- Subject: Re: [RFA]: Modified Watchthreads Patch
- References: <41B8E16D.6070505@redhat.com> <01c4deb2$Blat.v2.2.2$ce83b6e0@zahav.net.il>
On Fri, Dec 10, 2004 at 02:20:39PM +0200, Eli Zaretskii wrote:
> Hmm... the new function insert_watchpoints_for_new_thread is called
> only by ia64_linux_new_thread. Is there any policy for functions that
> are only used by a single port? Do we care that all the other GDB
> builds will get a useless function compiled into them? Should we
> perhaps #ifdef it away conditioned on some symbol?
Let's not. Conditional compilation is bad... if it were more than a
single function, we could move it into its own file.
However, I think ia64_linux_new_thread's use should be taken as an
example. If I understand Jeff's patch correctly, a number of other
targets with hardware watchpoints will need it also.
--
Daniel Jacobowitz