This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/dwarf] Support for attributes pointing to a different CU
- From: Daniel Jacobowitz <drow at false dot org>
- To: Jim Blandy <jimb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 3 Oct 2004 12:16:21 -0400
- Subject: Re: [rfa/dwarf] Support for attributes pointing to a different CU
- References: <20040923045723.GA11871@nevyn.them.org> <vt2u0tobpf1.fsf@zenia.home> <20040924003412.GB10500@nevyn.them.org> <vt2k6ucua6b.fsf@zenia.home>
On Wed, Sep 29, 2004 at 02:50:20PM -0500, Jim Blandy wrote:
>
> > @@ -4610,6 +4821,9 @@ read_subrange_type (struct die_info *die
> > low = 1;
> > }
> >
> > + /* FIXME: For variable sized arrays either of these could be
> > + a variable rather than a constant value. We'll allow it,
> > + but we don't know how to handle it. */
> > attr = dwarf2_attr (die, DW_AT_lower_bound, cu);
> > if (attr)
> > low = dwarf2_get_attr_constant_value (attr, 0);
>
> This should be committed separately.
OK, done as below.
--
Daniel Jacobowitz
2004-10-03 Daniel Jacobowitz <dan@debian.org>
* dwarf2read.c (read_subrange_type): Add comment for variable
sized arrays.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.163
diff -u -p -r1.163 dwarf2read.c
--- dwarf2read.c 21 Sep 2004 15:04:41 -0000 1.163
+++ dwarf2read.c 3 Oct 2004 16:14:23 -0000
@@ -4610,6 +4610,9 @@ read_subrange_type (struct die_info *die
low = 1;
}
+ /* FIXME: For variable sized arrays either of these could be
+ a variable rather than a constant value. We'll allow it,
+ but we don't know how to handle it. */
attr = dwarf2_attr (die, DW_AT_lower_bound, cu);
if (attr)
low = dwarf2_get_attr_constant_value (attr, 0);