Re: [testsuite] Add test for setting breakpoints by full path

[Michael Chastain <mec dot gnu at mindspring dot com>]

[I'm back ... hello mailbox backlog!]

Pretty good, but I see some nits:

. fullname.c needs to #include <stdio.h> to avoid a warning with
  gcc 4.0.0 about implicit internal function on printf.

. test the return value on "file copy -force ..."

. In the call to gdb_get_line_number, it's not necessary to call
  gdb_exit / gdb_start / gdb_load before and after the call to
  gdb_get_line_number.  The new gdb_get_line_number is pure TCL
  code that greps the file without talking to gdb, so you don't
  have to initialize gdb before using it.

. In gdb_breakpoint, only allow-pending or no-message can be used,
  but not both, because both tests use [lindex $args 0].  Either
  document this bit of cheesiness and leave it for the future to fix,
  or get in and fix the TCL.

Michael

2004-09-19  Daniel Jacobowitz  <dan@debian.org>

	* gdb.base/fullname.c: New file.
	* gdb.base/fullname.exp: New file.
	* lib/gdb.exp (gdb_breakpoint): Support no-message option.