This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] fix problems with unwinder on mips-irix


Andrew,


If you've the time, please do.

Two key things to know:

- with three unwinders handling three different cases previously handled by one, there's a lot of dead code paths. For instance, mips32_heuristic_proc_desc is now only called by mips_insn32_frame_cache and hence can be inlined there, making it possible for your problem to be solved more locally.

- I'm interested in a brutal overhaul of an unwinder, not a small tweak :-)


I think I can find the time for "a small tweak" within the next couple
of weeks, maybe this week-end. But if a "brutal overhaul" is required,
then the bar is too high for me. I just don't have the time.

I think that you'll find that a brutal overhaul will in the end take less time than what, at first sight, appears to be just a single simple wafer thin tweak.


Here we've got what should be a single simple procedure (mips_insn32_frame_cache) with a very tight interface and an exaustive testsuite, but instead is anything but.

Can I suggest spending just an hour attacking it, and then posting the result (just as long as it compiles :-).

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]