This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] read_reg() patch

   From: "Martin M. Hunt" <hunt@redhat.com>
   Date: Mon, 26 Jul 2004 13:57:34 -0700

   > I also think that the code itself is pretty unreadable.  There are too
   > many nested function calls.  I think it could be improved by using a
   > (temporary) local variable to store the result of
   > extract_unsigned_integer().

   How's this?

   2004-07-26  Martin Hunt  <hunt@redhat.com>
	   * dwarf2-frame.c (read_reg): Add a call to
	   store_unsigned_integer.

Great, although I'd chose a somewhat less generic name for the
variable than `tmp'; although the `val' I've got in mind is pretty
generic too :-(.  However, the type shouldn't be CORE_ADDR, but
ULONGEST.  Consider a patch with that change pre-approved.

Mark
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]