This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/m32r] Fix breakpoint bug of m32rsdi protocol; remote-m32r-sdi.c re-indented.


Andrew,

I revised my patch.

> I've committed the attached which re-indents remote-m32r-sdi.c using
> gdb/gdb_indent.sh.  You'll want to merge in that change and strip out
> any other stray mods.

I've merged these changes.

> can you add helper functions like:
>   send_l4_data (SDI_WRITE_MEMORY, 0xffff8200 + 4 * i, 4, 0xffffffff);
> for each of these cases (and any others you feel useful).

I added several helper functions. Some sequences still remain because
they are unique. But most sequences are replaced with helper functions.

OK to commit?

===

2004-07-26    Kei Sakamoto  <sakamoto.kei@renesas.com>

* remote-m32r-sdi.c: Fix breakpoint bug.
  (send_cmd, send_one_arg_cmd, send_two_arg_cmd, send_three_arg_cmd,
  recv_char_data, recv_long_data): New functions to replace communication
  sequences.

Attachment: remote-m32r-sdi.c.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]