This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Proper _to_regnum for DWARF on Cygwin
- From: Mark Kettenis <kettenis at chello dot nl>
- To: ford at vss dot fsi dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 30 Apr 2004 22:19:12 +0200 (CEST)
- Subject: Re: [PATCH] Proper _to_regnum for DWARF on Cygwin
- References: <Pine.GSO.4.58.0404131433490.29901@thing1-200>
Date: Tue, 20 Apr 2004 11:30:22 -0500
From: Brian Ford <ford@vss.fsi.com>
Oops, missed the comment refering to the removed function. Updated patch
attached. ChangeLog unchanged from below. Ok to apply?
Yes, please add yourself to the MAINTERS file under "Write After
Approval". After you've done so, please check in the patch
seperately.
Cheers,
Mark
On Mon, 19 Apr 2004, Brian Ford wrote:
> On Mon, 19 Apr 2004, Mark Kettenis wrote:
>
> > Hmm. I very much agree with what Brian wrote in his follow-up
> > messages. I think DJGPP is doing the right thing using the SVR4
> > scheme for DWARF2 while staying backwards compatible for stabs. I'd
> > advise him to do the same for cygwin.
>
> Ok, do I need approval to revert my own patch ;-) ?
>
> 2004-04-19 Brian Ford <ford@vss.fsi.com>
>
> Revert 2004-04-16 change.
> * i386-tdep.c (i386_gdbarch_init): Fix comment typos.
> (i386_coff_init_abi): Remove.
> * i386-tdep.h (i386_coff_init_abi): Remove.
> * i386-cygwin-tdep.c (i386_cygwin_init_abi): Remove call to above.
>
> > If i386_coff_init_abi will be gone, the comments aren't contradictiory
> > anymore.