This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: build failure due to observer.sh


I don't think so, just sounds like it isn't a common extension, do the
comments need to be in column one?


Moving the comments to column one seems to be fixing the problem.
I tested the attached patch on ppc-aix 5.1 (/usr/bin/sed),
alpha-tru64 5.1 (/usr/bin/sed), and solaris 2.5+2.8 (usr/xpg4/bin/sed).
It worked in all cases.


Having this built on-demand is one of the departures from gdbarch.sh (and why I committed this now, so early in a release cycle). I'd like to see how unfixable the problem is before abandoning the idea.


OK. I tend to prefer to have all files under revision control, generated
files included. That's because when somebody tells us about a problem,
we are certain about the sources he used. If some of the files are
generated on demand, then we have to consider the possibility of him
having experienced a problem during the generation.

[picking other half of thread]


What about doing the same as for .y and .l files? Generate them when not there, but also bundle generated versions as part of the distro? Aat one stage the repository did contain generated lex/yacc files but they were removed as they were often out-of-sync and/or badly date-stamped.

Andrew

(for configure, yes, I agree that it should be generated, it's just to big, complicated, and exposed to the local SH version's wim.)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]