Re: stabsread, struct wipeout, missing type

[Jim Blandy <jimb at redhat dot com>]

Felix Lee <felix@specifixinc.com> writes:
> when gdb sees the second occurrence of struct ace,
> it looks up the type number (3,2),
> which refers to ace.h,
> which is the same as the earlier ace.h,
> so gdb reuses the previously-defined ace type.
> 
> then gdb complains about struct wipeout and ignores the second definition,
> which means it misses the type definition (2,1)=*(0,2),
> which means cap_t uses an undefined type,
> so "ptype cap_t" prints "struct <unknown>" instead of "char *".

Wow, great find.

I don't think the patch is the whole story, though.  Consider this
case:

$ cat h1.h
typedef struct a a_t;
$ cat c1.c
#include "h1.h"

struct a
{
  int x, y;
};

a_t v2;

int
main ()
{
}

$ cat c2.c
#include "h1.h"

struct a
{
  double c, d;
};

a_t v1;
$ gcc33 gcc c1.c c2.c -o c -gstabs+
$ gdb c
GNU gdb 2004-02-17-cvs
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...Using host libthread_db library "/lib/libthread_db.so.1".

(gdb) ptype v1
During symbol reading, struct/union type gets multiply defined: struct a.
type = struct a {
    int x;
    int y;
}
(gdb) ptype v2
type = struct a {
    int x;
    int y;
}
(gdb)

I think it's just wrong for GDB to be re-using incomplete types from
EXCL'd header files.  Because C has no global names rule like C++ (I
forget what it's really called), there's no guarantee that the type
is actually the same.

As far as I can see, GDB has always done this.  I can't believe it's
never been noticed before.

I've attached a test case for both the problem you reported, and the
problem I describe above.  It's got a kfail for my problem, but I
don't have a PR number yet for yours (I filed it as as separate PR,
since the fix will be separate).

I think your fix looks good.  We don't have a copyright assignment on
file for you; I'll get that started off-list.

2004-04-01  Jim Blandy  <jimb@redhat.com>

	* gdb.stabs/exclfwd.exp, gdb.stabs/exclfwd1.c,
	gdb.stabs/exclfwd2.c, gdb.stabs/exclfwd.h: New test.

Index: gdb/testsuite/gdb.stabs/exclfwd.exp
===================================================================
RCS file: gdb/testsuite/gdb.stabs/exclfwd.exp
diff -N gdb/testsuite/gdb.stabs/exclfwd.exp
*** gdb/testsuite/gdb.stabs/exclfwd.exp	1 Jan 1970 00:00:00 -0000
--- gdb/testsuite/gdb.stabs/exclfwd.exp	1 Apr 2004 20:13:05 -0000
***************
*** 0 ****
--- 1,68 ----
+ #   Copyright 2004 Free Software Foundation, Inc.
+ 
+ # This program is free software; you can redistribute it and/or modify
+ # it under the terms of the GNU General Public License as published by
+ # the Free Software Foundation; either version 2 of the License, or
+ # (at your option) any later version.
+ # 
+ # This program is distributed in the hope that it will be useful,
+ # but WITHOUT ANY WARRANTY; without even the implied warranty of
+ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ # GNU General Public License for more details.
+ # 
+ # You should have received a copy of the GNU General Public License
+ # along with this program; if not, write to the Free Software
+ # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
+ 
+ # Please email any bugs, comments, and/or additions to this file to:
+ # bug-gdb@gnu.org
+ 
+ if $tracelevel {
+     strace $tracelevel
+ }
+ 
+ #
+ # test running programs
+ #
+ set prms_id 0
+ set bug_id 0
+ 
+ set testfile exclfwd
+ set binfile ${objdir}/${subdir}/${testfile}
+ 
+ foreach file {exclfwd1 exclfwd2} {
+     if {[gdb_compile "${srcdir}/${subdir}/${file}.c" "${file}.o" object {debug}] != ""} {
+         gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+     }
+ }
+ 
+ if {[gdb_compile "exclfwd1.o exclfwd2.o" ${binfile} executable {debug}] != "" } {
+      gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+ }
+ 
+ gdb_exit
+ gdb_start
+ gdb_reinitialize_dir $srcdir/$subdir
+ gdb_load ${binfile}
+ 
+ if ![runto_main] then {
+     perror "couldn't run to breakpoint"
+     continue
+ }
+ 
+ get_debug_format
+ 
+ set eol "\[ \t\]*\[\n\r\]+"
+ 
+ gdb_test "ptype v1" "type = struct a {$eol
+     int x;$eol
+     int y;$eol
+ }$eol"
+ 
+ if { [test_debug_format "stabs"] } then {
+     setup_kfail "gdb/1602" *-*-*
+ }
+ gdb_test "ptype v2" "type = struct a {$eol
+     const char .c;$eol
+ }$eol"
+ gdb_test "ptype v3" "type = const char ."
Index: gdb/testsuite/gdb.stabs/exclfwd.h
===================================================================
RCS file: gdb/testsuite/gdb.stabs/exclfwd.h
diff -N gdb/testsuite/gdb.stabs/exclfwd.h
*** gdb/testsuite/gdb.stabs/exclfwd.h	1 Jan 1970 00:00:00 -0000
--- gdb/testsuite/gdb.stabs/exclfwd.h	1 Apr 2004 20:13:05 -0000
***************
*** 0 ****
--- 1 ----
+ typedef struct a a_t;
Index: gdb/testsuite/gdb.stabs/exclfwd1.c
===================================================================
RCS file: gdb/testsuite/gdb.stabs/exclfwd1.c
diff -N gdb/testsuite/gdb.stabs/exclfwd1.c
*** gdb/testsuite/gdb.stabs/exclfwd1.c	1 Jan 1970 00:00:00 -0000
--- gdb/testsuite/gdb.stabs/exclfwd1.c	1 Apr 2004 20:13:05 -0000
***************
*** 0 ****
--- 1,14 ----
+ #include "exclfwd.h"
+ 
+ struct a 
+ {
+   int x, y;
+ };
+ 
+ a_t v1;
+ 
+ int
+ main ()
+ {
+ }
+ 
Index: gdb/testsuite/gdb.stabs/exclfwd2.c
===================================================================
RCS file: gdb/testsuite/gdb.stabs/exclfwd2.c
diff -N gdb/testsuite/gdb.stabs/exclfwd2.c
*** gdb/testsuite/gdb.stabs/exclfwd2.c	1 Jan 1970 00:00:00 -0000
--- gdb/testsuite/gdb.stabs/exclfwd2.c	1 Apr 2004 20:13:05 -0000
***************
*** 0 ****
--- 1,9 ----
+ #include "exclfwd.h"
+ 
+ struct a
+ {
+   const char *c;
+ };
+ 
+ a_t v2;
+ const char *v3;