This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: make execute_control_command conform to docs
That patch looks good to me. I was also able to apply it to the gdb
tree in 'crash' where I originally discovered the problem, and the
segfault there is gone.
Thanks for all the help!
Just committing, ...
Andrew
Tue, 2004-02-24 at 18:12, Andrew Cagney wrote:
> I was trying to make the patch as small as possible, but I ought to have
> done it as you say. Letting everything flow through to the end so that
> there is only one return point is definitely the cleanest way to do it.
Here, yes, it appears to be the case. Any way, does the attached appear
to work?
Andrew
______________________________________________________________________
2004-02-24 Andrew Cagney <cagney@redhat.com>
PR cli/1566. Problem found, and fix suggested by David Allan.
* cli/cli-script.c (execute_control_command): Unconditionally
install a cleanup. Default "ret" to "invalid_control". Use
"break" instead of "return" to escape from the switch.