This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC]: new set breakpoint pending and show breakpoint pending commands


> Date: Tue, 10 Feb 2004 19:18:41 -0500
> From: Jeff Johnston <jjohnstn@redhat.com>
> 
> I have included a doc patch but will wait on posting a change to pending.exp 
> until everyone is ok with the interface.  A change is not required to make 
> pending.exp work, it would just exercise the new functionality.  I have tested 
> the new settings manually.
> 
> Ok?

Thanks.  A few minor comments about the documentation patch:

> +If a specified breakpoint location cannot be found, it may due to the fact
                                                            ^^^
I think there's a "be" missing at the spot I marked.

> +that the location is in a shared library that is yet to be loaded.  In such
> +a case, you may want @value{GDBN} to create a special breakpoint (known as
> +a pending breakpoint) that

Please put "pending breakpoint", just this once, in @dfn{}, so that it
stands out.  (This is generally a good practice when introducing new
terminology.)

>                       When a breakpoint location is unrecognized,
> +you are queried to see if a pending breakpoint should be created.

I'd rephrase this slightly:

   When @value{GDBN} cannot find the breakpoint location, it queries
   you whether a pending breakpoint should be created.

Otherwise, it can go in when the code patch is approved.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]