This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] Change xfail to kfail in call-ar-st.exp
- From: Mark Kettenis <kettenis at chello dot nl>
- To: gdb-patches at sources dot redhat dot com
- Date: Sun, 1 Feb 2004 11:21:42 +0100 (CET)
- Subject: [PATCH] Change xfail to kfail in call-ar-st.exp
It's GDB's fault that this test is failing, so I filed a PR and
checked in this patch to kfail instead of xfail.
Checked in as obvious,
Mark
Index: testsuite/ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* gdb.base/call-ar-st.exp: Call get_debug_format. Remove xfail on
sparc*-*-solaris* into a kfail PR gdb/1539 on sparc-*-* for stabs
only on the "print_small_structs from print_long_arg_list" test.
Index: testsuite/gdb.base/call-ar-st.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/call-ar-st.exp,v
retrieving revision 1.13
diff -u -p -r1.13 call-ar-st.exp
--- testsuite/gdb.base/call-ar-st.exp 6 Jan 2004 19:05:14 -0000 1.13
+++ testsuite/gdb.base/call-ar-st.exp 1 Feb 2004 10:15:00 -0000
@@ -105,6 +105,8 @@ if ![runto_main] then {
continue
}
+get_debug_format
+
#go -until 1209
gdb_test "tbreak 1209" \
"Breakpoint \[0-9\]+.*file.*$srcfile, line 1209.*" \
@@ -500,11 +502,14 @@ set ws "\[\n\r\t \]+"
if {![gdb_skip_float_test "print_small_structs from print_long_arg_list"] && \
![gdb_skip_stdio_test "print_small_structs from print_long_arg_list"] } {
- # On Solaris, some of the args are passed by ref, others by value,
- # and GDB gets confused and says "Invalid cast" because it thinks
- # it has to cast the structure into a pointer to structure. A real
- # GDB bug, probably for all Sparc configs, but obscure. -sts 1999-08-17.
- setup_xfail "sparc*-*-solaris*"
+
+ # On 32-bit SPARC, some of the args are passed by ref, others by
+ # value, and GDB gets confused and says "Invalid cast" because it
+ # thinks it has to cast the structure into a pointer to structure.
+ if { [test_debug_format "stabs"] } then {
+ setup_kfail "gdb/1539" "sparc-*-*"
+ }
+
send_gdb "print print_small_structs(struct1, struct2, struct3, struct4, flags, flags_combo, three_char, five_char, int_char_combo, d1, d2, d3, f1, f2, f3)\n"
gdb_expect_list "print print_small_structs from print_long_arg_list" ".*$gdb_prompt $" {
"\[\t\r\n \]+alpha"