Re: [rfa/symtab] Move find_pc_section call tolookup_minimal_symbol_by_pc

[Adam Fedor <fedor at doc dot com>]

On Thu, 2004-01-29 at 13:13, Elena Zannoni wrote:
> Andrew Cagney writes:
>  > Hello,
>  > 
>  > Ref: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries)
>  > http://sources.redhat.com/ml/gdb-patches/2003-07/msg00354.html
>  > 
>  > The change unfortunatly broke IRIX 6.5's host compiler which is using 
>  > mdebugread :-(  That code was looking for a symbol in the absolute 
>  > section "*ABS*" but the PR/1267 change was causing *ABS* symbols to be 
>  > ignored (find_pc_section didn't return an absolute section).
>  > 
>  > Since the underlying problem with PR/1267 was with the frame code 
>  > needing a minimal symbol that was in the same section as the frame's PC, 
>  > and that code [indirectly] calls lookup_minimal_symbol_by_pc, I moved 
>  > the find_pc_section call to that function.
>  > 
>  > Tested on i386 GNU/Linux (dwarf 2) with no regressions.
>  > Tested on PPC NetBSD (stabs) with no regressions.
>  > Tested on IRIX and all the warnings, and many failures, disappeared.
>  > See gdb/1519 for how to exercise the bug.
>  > 
>  > ok?
> 
> ok. Does it still fix shlibs/1237 and shlibs/1280 too? Adam, could you
> check please?
> 
> elena

No. It breaks again. I get:

localhost /home/users/fedor/src/CSharedLib>../gdb-build/gdb/gdb
simple_share 
GNU gdb 2004-01-29-cvs
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you
are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for
details.
This GDB was configured as "powerpc-unknown-linux-gnu"...Using host
libthread_db library "/lib/libthread_db.so.1".

(gdb) break main
Breakpoint 1 at 0x10001778: file testit.c, line 7.
(gdb) run
Starting program: /home/users/fedor/src/CSharedLib/simple_share 

Breakpoint 1, main () at testit.c:7
7         hithere2();
(gdb) s
0x30024f60 in ?? () from /lib/ld.so.1
(gdb) bt
#0  0x30024f60 in ?? () from /lib/ld.so.1
(gdb) n
Single stepping until exit from function __cache_line_size, 
which has no line number information.
here is were you type next (n)
hi there 

Program exited normally.
(gdb)