This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[PATCH] Reformat blockframe.c:inside_entry_func()
- From: Mark Kettenis <kettenis at chello dot nl>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 10 Jan 2004 01:10:02 +0100 (CET)
- Subject: [PATCH] Reformat blockframe.c:inside_entry_func()
In preparation of some real changes. Checked in as obvious.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* blockframe.c (inside_entry_func): Reformat. Introduce new local
variables to prevent long lines. Update comments to reflect
reality.
Index: blockframe.c
===================================================================
RCS file: /cvs/src/src/gdb/blockframe.c,v
retrieving revision 1.84
diff -u -p -r1.84 blockframe.c
--- blockframe.c 16 Dec 2003 21:23:50 -0000 1.84
+++ blockframe.c 10 Jan 2004 00:08:55 -0000
@@ -156,13 +156,10 @@ inside_main_func (CORE_ADDR pc)
&& symfile_objfile->ei.main_func_highpc > pc);
}
-/* Test a specified PC value to see if it is in the range of addresses
- that correspond to the process entry point function. See comments
- in objfiles.h for why we might want to do this.
+/* Test whether PC is inside the range of addresses that corresponds
+ to the process entry point function.
- Typically called from DEPRECATED_FRAME_CHAIN_VALID.
-
- A PC of zero is always considered to be the bottom of the stack. */
+ A PC of zero is always considered to be the bottom of the stack. */
int
inside_entry_func (CORE_ADDR pc)
@@ -171,16 +168,19 @@ inside_entry_func (CORE_ADDR pc)
return 1;
if (symfile_objfile == 0)
return 0;
+
if (CALL_DUMMY_LOCATION == AT_ENTRY_POINT)
{
- /* Do not stop backtracing if the pc is in the call dummy
- at the entry point. */
- /* FIXME: Won't always work with zeros for the last two arguments */
+ /* Do not stop backtracing if the program counter is in the call
+ dummy at the entry point. */
+ /* FIXME: This won't always work with zeros for the last two
+ arguments. */
if (DEPRECATED_PC_IN_CALL_DUMMY (pc, 0, 0))
return 0;
}
- return (symfile_objfile->ei.entry_func_lowpc <= pc &&
- symfile_objfile->ei.entry_func_highpc > pc);
+
+ return (symfile_objfile->ei.entry_func_lowpc <= pc
+ && symfile_objfile->ei.entry_func_highpc > pc);
}
/* Return nonzero if the function for this frame lacks a prologue. Many