This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFC] Fix compilation warning in breakpoint.c
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Mark Kettenis <kettenis at chello dot nl>, gdb-patches at sources dot redhat dot com
- Date: Fri, 12 Dec 2003 14:53:08 -0700
- Subject: Re: [PATCH/RFC] Fix compilation warning in breakpoint.c
- References: <200312111345.hBBDjIew000479@elgar.kettenis.dyndns.org>
On Dec 11, 2:45pm, Mark Kettenis wrote:
> The newest GCC complains about us passing NULL as one of the arguments
> to strcmp(). This patch fixes the problem. It's similar to what we
> do for SOLIB_LOADED_LIBRARY_PATHNAME. I wonder whether is would be
> better to get rid of these definitions in solib.h altogether, and rely
> on the defaults in breakpoint.h. Thoughts?
I think it makes sense to remove the solib.h definitions that
breakpoint.h already provides defaults for. If you want to do this,
consider the solib.h changes to be preapproved.
Kevin