This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] stabs: remember types that cross reference another type


> Yes, but the comment before that loop you are changing needs some
> revamping. Reading it, it really looks like it is a useless/obsoleted
> thing we are doing here, while now it's not the case anymore. I mean,
> it is useful.

yes, I agree. I am not sure how much information to keep though.
Would the following be ok?

  /* If this type has already been declared, then reuse the same type
     rather than allocating a new one.  This saves some memory.  */

The current comment is:

        /* Now check to see whether the type has already been
           declared.  This was written for arrays of cross-referenced
           types before we had TYPE_CODE_TARGET_STUBBED, so I'm pretty
           sure it is not necessary anymore.  But it might be a good
           idea, to save a little memory.  */

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]