That's not what I'm asking.
With the call to inside_entry_func removed, from get_prev_frame, can you
point me at any remainng _legitimate) uses of that function?
The other call to it in legacy_frame_chain_valid, which wants to know
the same thing? I imagine the third caller, in frv-tdep.c, is bogus
and could be removed somehow. But if it's going to be left there then
it seems reasonable to update it also.
Conceptually the patch you just posted sees to be:
- Change the implementation of inside_entry_func
- Inline the new inside_entry_func into the one caller you're fond of
- Add a deprecated copy of the old implementation for the other
callers
From the man who is always telling us how unimportant performance is
compared to clarity, I don't see the point. Also, this leaves an old
implementation and a new implementation around for no visible reason.