This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Fix shreloc.exp test driver to pass additional flags whenlinking
- From: Nick Clifton <nickc at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: Daniel Jacobowitz <drow at mvista dot com>
- Date: Mon, 10 Nov 2003 13:08:01 +0000
- Subject: Re: RFA: Fix shreloc.exp test driver to pass additional flags whenlinking
- References: <m3ekwklaio.fsf@redhat.com><20031107143153.GA26353@nevyn.them.org> <m3ptg4jftp.fsf@redhat.com><20031107164045.GA32117@nevyn.them.org>
Hi Guys,
> Daniel Jacobowitz <drow@mvista.com> writes:
>> On Fri, Nov 07, 2003 at 04:36:50PM +0000, Nick Clifton wrote:
>>
>> > An arm-elf toolchain doesn't have shared library support, does it?
>> > Then the test should probably be disabled.
>>
>> Is there an official way to do this. I could create a new dejagnu
>> variable along the lines of:
>>
>> set_board_info gdb,no_shared_libs 1
>>
>> and then this could be tested in shreloc.exp ?
>
> There's no particular way to do it - that would work or just
> disabling the test for [istarget *-elf] || [istarget *-coff] would
> work too.
Well that is certainly simpler. In which case, please may I have
approval to check in this patch ?
Cheers
Nick
gdb/testsuite/ChangeLog
2003-11-10 Nick Clifton <nickc@redhat.com>
* gdb.base/shreloc.exp: Do not run for targets which do not
support shared objects.
Index: gdb/testsuite/gdb.base/shreloc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/shreloc.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 shreloc.exp
*** gdb/testsuite/gdb.base/shreloc.exp 9 Jun 2003 21:23:53 -0000 1.1
--- gdb/testsuite/gdb.base/shreloc.exp 10 Nov 2003 13:05:18 -0000
***************
*** 23,28 ****
--- 23,33 ----
# them gets relocated at load-time. Check that gdb gets the right
# values for the debugging and minimal symbols.
+ if {[istarget *-elf*] || [istarget *-coff] || [istarget *-aout]} then {
+ verbose "test skipped - shared object files not supported by this target."
+ return 0
+ }
+
if $tracelevel then {
strace $tracelevel
}