Re: [patch/rfc] target read/write partial

[Daniel Jacobowitz <drow at mvista dot com>]

On Wed, Oct 15, 2003 at 06:16:28PM -0400, Andrew Cagney wrote:
> Hello,
> 
> This patch adds target read/write partial methods.
> 
> It's almost ready for prime time.  I want to first see through some 
> other target cleanups namely:
> +  /* FIXME: cagney/2003-10-15: This code should walk down the target
> +     stack looking for a stratum that supports the mechanism.
> +     Unfortunatly, there isn't a per-target-stack chain to walk round.
> +     Catch-22.  */
> and a s/target_ops/target/ transformation.

Preferably not target - didn't someone suggest gdbtarg?  Or maybe
gdb_target.

> 
> Note that it includes:
> +  /* Transfer up-to LEN bytes of memory starting at OFFSET.  */
> +  TARGET_OBJECT_MEMORY
> I'm going to need that when implementing a per-target 
> CONVERT_FROM_FUNC_PTR_ADDR.

How is that different from a memory read, which we've already got? I am
guessing that it's because you want to support partial memory
operations (avoid packet size limits), but you never explained your
goal.

> +  /* Map pre-existing objects onto letters.  DO NOT do this for new
> +     objects!!!  Instead specify new query packets.  */

Could that be a little clearer - I had to read the code a couple of
times to figure out what you meant.  I guess you just want to say that
there's no need to use single letters?

> +  /* Minimum outbuf size is (rs->remote_packet_size) - if bufsiz is
> +     not large enough let the caller.  */

Missing a word there I think.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer