This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Use program_transform_name correctly


On Tue, Oct 07, 2003 at 04:59:21PM -0700, Felix Lee wrote:
> Daniel Jacobowitz <drow@mvista.com>:
> > Eh, you're right, this will teach me to answer without looking.  From
> > gcc/Makefile.in:
> >        t='$(program_transform_cross_name)'; echo ar | sed -e $$t ; \
> > That's the idiom we should use here.
> 
> yeah, $$t should be unquoted because configure does the quoting,
> so that a transformation that has quotes will work correctly.
> however, this is only for "recent" versions of autoconf, where
> recent is "some version of autoconf after 2.13 that still says
> 'generated by 2.13' at the top of configure".
> 
> autoconf 2.13 and before will sometimes leave
> program_transform_name null, which will cause that sed to fail.

How horrid.

> the newer autoconfs will make sure program_transform_name is
> 's,x,x,' if it would otherwise be null.

Conveniently this is no longer an issue in the src repository (or in
gcc).  The toplevel configure script now guarantees that
$(program_transform_name) will not be empty.  So $$t it is.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]