This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs)
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 1 Oct 2003 16:37:03 -0400
- Subject: Re: SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs)
- References: <20030917161127.GM9981@cygbert.vinschen.de><16240.45203.260059.116019@localhost.redhat.com><20030924095552.GA8414@cygbert.vinschen.de><16243.25282.58326.132364@localhost.redhat.com><20030926111405.GG22787@cygbert.vinschen.de>
Corinna Vinschen writes:
> On Thu, Sep 25, 2003 at 05:48:50PM -0400, Elena Zannoni wrote:
> > Corinna Vinschen writes:
> > > Ok, step 1:
> >
> > Seems ok, are there diffs in the test results before&after?
>
> No.
>
> > Are these
> > explanations also in the code?
>
> Yes.
>
> > > If you don't like that and want to use register_size correctly in that case,
> > > it would have to look like this:
> >
> > Yes please.
> >
> > When you are done with this rewrite, it would be good to pass the file
> > through gdb_indent.sh.
>
> Yes. Anything else left before approval?
>
No, but check in the patch with the changes corresponding to the
changelog entries below.
After that, check in the reindentation, and add a new changelog entry
saying you ran it through gdb_indent.sh.
thanks
elena
ChangeLog:
==========
* sh-tdep.c (sh_justify_value_in_reg): New function.
(sh_stack_allocsize): Ditto.
(flt_argreg_array): New array used for floating point argument
passing.
(sh_init_flt_argreg): New function.
(sh_next_flt_argreg): Ditto.
(sh_push_dummy_call_fpu): Simplify. Rename "odd_sized_struct" to
"pass_on_stack". Use new helper functions. Accomodate Renesas ABI.
Fix argument passing strategy.
(sh_push_dummy_call_nofpu): Ditto.