This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: SH follow up, part 1 (was Re: [RFA] sh-tdep.c: Follow up patch to implement two different ABIs)


Corinna Vinschen writes:
 > On Thu, Sep 25, 2003 at 05:48:50PM -0400, Elena Zannoni wrote:
 > > Corinna Vinschen writes:
 > >  > Ok, step 1:
 > > 
 > > Seems ok, are there diffs in the test results before&after?
 > 
 > No.
 > 
 > >   Are these
 > > explanations also in the code?
 > 
 > Yes.
 > 
 > > > If you don't like that and want to use register_size correctly in that case,
 > > > it would have to look like this:
 > > 
 > > Yes please.
 > > 
 > > When you are done with this rewrite, it would be good to pass the file
 > > through gdb_indent.sh.
 > 
 > Yes.  Anything else left before approval?
 > 

No, but check in the patch with the changes corresponding to the
changelog entries below.

After that, check in the reindentation, and add a new changelog entry
saying you ran it through gdb_indent.sh.

thanks
elena

ChangeLog:
==========

	* sh-tdep.c (sh_justify_value_in_reg): New function.
	(sh_stack_allocsize): Ditto.
	(flt_argreg_array): New array used for floating point argument
	passing.
	(sh_init_flt_argreg): New function.
	(sh_next_flt_argreg): Ditto.
	(sh_push_dummy_call_fpu): Simplify. Rename "odd_sized_struct" to
	"pass_on_stack". Use new helper functions.  Accomodate Renesas ABI.
	Fix argument passing strategy.
	(sh_push_dummy_call_nofpu): Ditto.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]