This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Properly define SSE registers for cygwin targets
- From: Mark Kettenis <kettenis at chello dot nl>
- To: cgf at redhat dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 13 Sep 2003 13:02:59 +0200 (CEST)
- Subject: Re: [PATCH] Properly define SSE registers for cygwin targets
- References: <20030913022759.GA2225@redhat.com>
Date: Fri, 12 Sep 2003 22:27:59 -0400
From: Christopher Faylor <cgf@redhat.com>
Checked in, trunk and branch.
cgf
2003-09-12 Christopher Faylor <cgf@redhat.com>
* win32-nat.c: Reorganize so that defines used by target headers are
actually defined by the system headers.
* config/i386/tm-cygwin.h: Check for CONTEXT_EXTENDED_REGISTERS rather
than HAVE_CONTEXT_EXTENDED_REGISTERS, since the latter actually exists.
Hmm, this looks like a lost opportunity to get rid of a definition in
tm-cygwin.h. HAVE_SSE_REGS has been eliminated from all source files
except win32-nat.c. So a s/HAVE_SSE_REGS/CONTEXT_EXTENDED_REGISTERS/g
in that file would have been sufficient. This also removes the need
to re-order the includes; out coding standards say that "defs.h"
should always come first. Oh and the #include "tm.h" is bogus, since
"defs.h" already does that.
It would be great if you could clean up things along those lines. The
"tm-cygwin.h" still contains a lot of stuff that doesn't belong there.
Mark