This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Trivial fix to annota1.exp
- From: Jim Ingham <jingham at apple dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 12 Sep 2003 13:31:41 -0700
- Subject: Trivial fix to annota1.exp
I think that the backtrace through a signal handler test in annota1.exp
is wrong. It uses a "*" in the regexp for the part that is looking for
the signal handler frame. Because of that, all the test really does is
count the number of frames, and require they be three or more frames.
It doesn't check that a signal frame is on the stack at all.
I think you really need a "+" instead, or I don't understand the point
of the test.
Is this okay, it still passes on Linux...
Index: annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.12
diff -r1.12 annota1.exp
299c299
< -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1
$hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler
called.\r\n\r\n)*\032\032frame-end\r\n\r\n\032\032frame-begin 2
$hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" {
---
> -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1
$hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler
called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2
$hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" {
Jim
--
Jim Ingham jingham@apple.com
Developer Tools
Apple Computer