This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: AHAH! Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step

On Sep 9,  1:01pm, Jimi Xenidis wrote:

> >>>>> "KB" == Kevin Buettner <kevinb@redhat.com> writes:
> 
>  KB> Ideally, we'd have a GDB_OSABI_AIX constant to use for the test.
> 
> ok, but I'll be using the if (from_xcoff_exec) early in the function
> to assign info.osabi to it.
> Is that acceptable for this patch, will submit if you agree.

I'd prefer to see GDB_OSABI_AIX set via a sniffer.  For the time
being, you can just use ``from_xcoff_exec'' for the test.  Please
add a comment which indicates that the test ought to be eventually
changed to use GDB_OSABI_AIX when it becomes available.  (Actually,
once things are properly split apart, the test goes away.)

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]