This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:threads] Report when using libthread_db


Michael Elizabeth Chastain writes:
 > Somebody's mailer expanded the tabs to spaces, which made me
 > do a little more work.  No big deal.  And it needs a ChangeLog.
 > 

I know it needs a CL, this was just something I had laying around to
see if it would help. I'll post a proper patch now. Not sure what
happened with the spaces.

 > Other than that, this patch works fine in my test bed.  It fixes the
 > problem all right.
 > 

thanks for testing it.

 > I would write it differently, with the "Reading symbols ..." as a common
 > part and then a "(|Using host libthread_db ...)".  But I'd like to just
 > get it done and move on to the next problem.
 > 

I can change that, it would shorten the pattern.

 > Recommended for approval, on HEAD only, not the branch.
 > The new message is not on the branch so this is not needed
 > on the branch.
 > 

ok
elena


 > Michael C
 > 
 > ===
 > 
 > --- gdb+dejagnu-5.3.90_20030710/gdb/testsuite/gdb.base/relocate.exp.1   Fri Aug 15 11:20:44 2003
 > +++ gdb+dejagnu-5.3.90_20030710/gdb/testsuite/gdb.base/relocate.exp     Fri Aug 15 11:23:31 2003
 > @@ -67,7 +67,7 @@ gdb_reinitialize_dir $srcdir/$subdir
 >  
 >  # Load the object file.
 >  gdb_test "add-symbol-file ${binfile} 0" \
 > -       "Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\." \
 > +       "(Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\.)|(Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\..*Using host libthread_db library .*libthread_db.so.*\\.)" \
 >         "add-symbol-file ${testfile}.o 0" \
 >         "add symbol table from file \".*${testfile}\\.o\" at\[ \t\r\n\]+\.text_addr = 0x0\[\r\n\]+\\(y or n\\) " \
 >         "y"
 > @@ -116,7 +116,7 @@ gdb_test "set \$offset = 0x10000" ""
 >  
 >  # Load the object file.
 >  gdb_test "add-symbol-file ${binfile} \$offset" \
 > -       "Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\." \
 > +       "(Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\.)|(Reading symbols from .*${testfile}\\.o\\.\\.\\.done\\..*Using host libthread_db library .*libthread_db.so.*\\.)" \
 >         "add-symbol-file ${testfile}.o \$offset" \
 >         "add symbol table from file \".*${testfile}\\.o\" at\[ \t\r\n\]+\.text_addr = 0x10000\[\r\n\]+\\(y or n\\) " \
 >         "y"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]