This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit/multiarch/hpux] set addr_bits_remove gdbarch method

HP/UX text addresses are word aligned, and we were already setting
the smash_text_address method for that. So I changed the gdbarch
init routine to set addr_bits_remove as well.

What caused me to look into this was the fact that I discovered that
we define the ADDR_BITS_REMOVE for hppa64, but not for hppa32, and
I think it is an oversight that was covered up by the fact that we
have SMASH_TEXT_ADDRESS was already.

I think we should have a look at getting rid of either one of these 2
methods. There is already a comment to that effect in gdbarch.h...


Yep: Consider merging SMASH_TEXT_ADDRESS with ADDR_BITS_REMOVE
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=333

Any one got a preference over which one goes? Otherwize, Joel, with HP/UX cleaned up, it should either way be pretty obvious.

nice,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]