This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: A.R. Index for GDB version 20030708


diff -u -r1.4499 ChangeLog
--- ChangeLog   8 Jul 2003 15:36:44 -0000       1.4499
+++ ChangeLog   8 Jul 2003 19:36:52 -0000
@@ -1,6 +1,9 @@
 2003-07-08  Kris Warkentin  <kewarken@qnx.com>

        * nto-procfs.c: Cleaned up a bunch of ARI hits.
+       Include "gdb_dirent.h" instead of <dirent.h>, replace all instances
+       of strerror with safe_strerror, use ISO C function definitions,
+       and replace instances of sprintf with snprintf.

cheers,

Kris

----- Original Message ----- 
From: "Andrew Cagney" <ac131313@redhat.com>
To: "Kris Warkentin" <kewarken@qnx.com>
Cc: "Gdb-Patches@Sources.Redhat.Com" <gdb-patches@sources.redhat.com>
Sent: Tuesday, July 08, 2003 2:53 PM
Subject: Re: A.R. Index for GDB version 20030708


> > 2003-07-08  Kris Warkentin  <kewarken@qnx.com>
> > 
> >  * nto-procfs.c: Cleaned up a bunch of ARI hits.
> > 
> 
> Kris, don't forget, the change log should specify what was changed, not 
> why.  For instance:
> 
> ...: Include "gdb_dirent.h" instead of <dirent.h", use strict ISO C, 
> use safe_strerror.  Clean up ARI hits.
> 
> I'd tweak the changelog,
> 
> Andrew
> 
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]