This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix a compilation failure in rs6000-nat.c


Hi Kevin,

Sorry it took me so long to get back to you. Our AiX machine suffered
a severe breakdown, and had to be completely reinstalled :(.

> I don't think this is quite right.  After looking at the other
> substitutions that were done along these lines[1], I think this should be:
> 
>      new_offsets = (struct section_offsets *)
> 	alloca (SIZEOF_N_SECTION_OFFSETS (objfile->num_sections));
> 
> Feel free to adjust the formatting.
> 
> If you agree that this is the correct fix, please apply this change
> to both the mainline and gdb 6.0 branch.  (But please post an updated
> patch showing what you committed.)

Good catch! 

Here is the patch I ended up committing, on mainline and branch.
That leaves only one more problem before GDB is able to build on
AiX again (xcoffread.c).

2003-07-04  Joel Brobecker  <brobecker@gnat.com>

        * rs6000-nat.c (vmap_symtab): Fix compilation error.

(note: I used gdb_indent's formatting)
-- 
Joel

Attachment: rs6000-nat.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]