This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[ob?] Separate instructions from addresses in the disassembler
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Wed, 2 Jul 2003 11:32:20 -0400
- Subject: [ob?] Separate instructions from addresses in the disassembler
A Debian user reported output like this:
0xbfff7ff8add %al,(%eax)
0xbfff7ffaadd %al,(%eax)
0xbfff7ffcadd %al,(%eax)
0xbfff7ffeadd %al,(%eax)
It turns out the separating tab was only being output if we had a symbol
name. I think it looks better this way:
0xbfff7000: add %al,(%eax)
0xbfff7002: add %al,(%eax)
0xbfff7004: add %al,(%eax)
Barring comments, I'll commit this in a few days. I think that putting a
6.0-branch prerelease into Debian/unstable was a good idea...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2003-07-02 Daniel Jacobowitz <drow@mvista.com>
* disasm.c (dump_insns): Separate instructions from addresses.
Index: disasm.c
===================================================================
RCS file: /cvs/src/src/gdb/disasm.c,v
retrieving revision 1.10
diff -u -p -r1.10 disasm.c
--- disasm.c 22 May 2003 23:00:15 -0000 1.10
+++ disasm.c 2 Jul 2003 15:29:32 -0000
@@ -123,6 +123,9 @@ dump_insns (struct ui_out *uiout, disass
ui_out_field_int (uiout, "offset", offset);
ui_out_text (uiout, ">:\t");
}
+ else
+ ui_out_text (uiout, ":\t");
+
if (filename != NULL)
xfree (filename);
if (name != NULL)