This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't clobber info->mach in gdb_print_insn_mips


> So you're ok if I delete that bit of gdb_print_insn_mips?

Works for me, though I assume that it was put there for a
reason.  Perhaps a better fix is something like:

  if (proc_desc)
    {
      if (pc_is_mips16 (PROC_LOW_ADDR (proc_desc))
        info->mach =  bfd_mach_mips16;
    }
  else
    {
      if (pc_is_mips16 (memaddr))
       info->mach = bfd_mach_mips16;
    }

which would leave info->mach alone unless pc_is_mips16 is true.

-Fred


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]