This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] Fix new failures in break.exp


On Tue, Jun 17, 2003 at 04:35:28PM -0400, Andrew Cagney wrote:
> >+    default:
> >+      warning ("Internal error, %s line %d.", __FILE__, __LINE__);
> >+      break;
> 
> Please, no.  If its an internal error, call internal_error.

I was just moving old code around.  But I've fixed it.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2003-06-19  Daniel Jacobowitz  <drow@mvista.com>

	* breakpoint.c (insert_catchpoint): Call internal_error.

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.123
diff -u -p -r1.123 breakpoint.c
--- breakpoint.c	17 Jun 2003 19:17:59 -0000	1.123
+++ breakpoint.c	19 Jun 2003 20:01:46 -0000
@@ -722,7 +722,7 @@ insert_catchpoint (struct ui_out *uo, vo
       val = target_insert_exec_catchpoint (PIDGET (inferior_ptid));
       break;
     default:
-      warning ("Internal error, %s line %d.", __FILE__, __LINE__);
+      internal_error (__FILE__, __LINE__, "unknown breakpoint type");
       break;
     }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]