This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Thu, 22 May 2003 12:41:29 -0700
- Subject: Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib
- References: <3ECD1E75.9020900@redhat.com>
On May 22, 3:01pm, Andrew Cagney wrote:
> This does the s/extract_address/extract_unsigned_integer/ change to the
> solib files.
>
> One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is
> ment to always sign extend an address. It's very tempting to instead
> make that code always do signextended extracts (I don't have access to
> an IRIX 4 box though).
>
> thoughts?
It looks okay to me.
I agree that extract_mips_address() in solib-irix.c probably ought to
be using extract_signed_integer(), but I too am reluctant to change it
without testing.
Why do you need an IRIX 4 box? Wouldn't IRIX 6 work?
Kevin