This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[dictionary] tests for RTTI warning


As various PR's attest, GDB has an annoying habit of printing a
message like

 warning: can't find class named `n2::D2', as given by C++ RTTI

when printing out classes defined in namespaces.  This is largely
fixed in my branch; this patch adds a test file gdb.c++/rtti.exp to
test for that.

One of the tests currently fails: it's a situation where G++ isn't
generating enough info for my branch to figure out that the class in
question lives in a namespace.  That's okay; there's nothing GDB can
do about that, and it's an artificially stripped test case which I
don't think would be likely to occur in real code.

I plan to commit a variant of this to mainline once I've pounded on it
a bit: I want to try this with a few different GCC versions first so I
know all the different messages that I'll see.  I'll post an RFC when
I do that.

David Carlton
carlton@bactrian.org

2003-05-02  David Carlton  <carlton@bactrian.org>

	* gdb.c++/rtti.h: New.
	* gdb.c++/rtti2.cc: New.
	* gdb.c++/rtti1.cc: New.
	* gdb.c++/rtti.exp: New.

2003-05-02  David Carlton  <carlton@bactrian.org>

	* config/djgpp/fnchange.lst: Add testsuite/gdb.c++/rtti files.

--- /dev/null	2002-08-30 16:31:37.000000000 -0700
+++ testsuite/gdb.c++/rtti.exp	2003-05-02 10:48:18.000000000 -0700
@@ -0,0 +1,112 @@
+# Copyright 2003 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+# 
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+# 
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
+
+# This file is part of the gdb testsuite.
+
+# This contains tests for GDB's use of RTTI information.  This stems
+# from a bug reported in PR gdb/488 and other places, which leads to
+# statements like 'warning: can't find class named 'C::D', as given by
+# C++ RTTI.  It arises from GDB not knowing about classes that are
+# defined in namespaces.
+
+# NOTE: carlton/2003-05-02: I suspect it could arise from nested class
+# issues, too, and even once we fix that, there might be situations
+# (involving templates, in particular) where this problem triggers
+# because GDB and GCC have different ideas what a class is called.
+
+if $tracelevel then {
+        strace $tracelevel
+        }
+
+if { [skip_cplus_tests] } { continue }
+
+#
+# test running programs
+#
+set prms_id 0
+set bug_id 0
+
+set testfile "rtti"
+set srcfile1 "${srcdir}/${subdir}/${testfile}1.cc"
+set objfile1 "${objdir}/${subdir}/${testfile}1.o"
+set srcfile2 "${srcdir}/${subdir}/${testfile}2.cc"
+set objfile2 "${objdir}/${subdir}/${testfile}2.o"
+set binfile ${objdir}/${subdir}/${testfile}
+
+# gdb_get_line_number needs this to be called srcfile.
+set srcfile "${srcfile1}"
+
+if  { [gdb_compile "${srcfile1}" "${objfile1}" object {debug c++}] != "" } {
+     gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+}
+
+if  { [gdb_compile "${srcfile2}" "${objfile2}" object {debug c++}] != "" } {
+     gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+}
+
+if  { [gdb_compile "${objfile1} ${objfile2}" "${binfile}" executable {debug c++}] != "" } {
+     gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+}
+
+if [get_compiler_info ${binfile} "c++"] {
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+
+if ![runto_main] then {
+    perror "couldn't run to breakpoint"
+    continue
+}
+
+# First, run to after we've constructed the object:
+
+gdb_breakpoint [gdb_get_line_number "constructs-done"]
+gdb_continue_to_breakpoint "end of constructors"
+
+gdb_test_multiple "print *e1" "print *e1" {
+    -re "warning: can't find class named `n1::D1', as given by C\\+\\+ RTTI.*$gdb_prompt $" {
+	kfail "gdb/488" "print *e1"
+    }
+    -re "\\$\[0-9\]* = {<n1::Base1> = .*}\r\n$gdb_prompt $" {
+	pass "print *e1"
+    }
+}
+
+# NOTE: carlton/2003-05-02: This test fails on my branch because,
+# within rtt1.cc, GDB has no way of knowing that the class is called
+# 'n2::D2' instead of just 'D2'.  This is an artifical test case,
+# though: if we were using these classes in a more substantial way,
+# G++ would emit more debug info.
+
+gdb_test_multiple "print *e2" "print *e2" {
+    -re "warning: can't find class named `n2::D2', as given by C\\+\\+ RTTI.*$gdb_prompt $" {
+	kfail "gdb/488" "print *e2"
+    }
+    -re "\\$\[0-9\]* = <incomplete type>\r\n$gdb_prompt $" {
+	kfail "gdb/TBA" "print *e2"
+    }
+    -re "\\$\[0-9\]* = {<n2::Base2> = .*}\r\n$gdb_prompt $" {
+	pass "print *e2"
+    }
+}
+
+gdb_exit
+return 0
--- /dev/null	2002-08-30 16:31:37.000000000 -0700
+++ testsuite/gdb.c++/rtti1.cc	2003-05-02 10:47:44.000000000 -0700
@@ -0,0 +1,67 @@
+/* Code to go along with tests in rtti.exp.
+   
+   Copyright 2003 Free Software Foundation, Inc.
+
+   Contributed by David Carlton <carlton@bactrian.org> and by Kealia,
+   Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or (at
+   your option) any later version.
+
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include "rtti.h"
+
+namespace n1 {
+
+  class C1;
+
+  class Base1 {
+  public:
+    virtual ~Base1() { }
+  };
+
+
+  class C1: public Base1 {
+  public:
+  };
+
+  class D1 : public C1{
+  public:
+    D1(C1 *, C1 *);
+    
+    C1* expr_1_;
+    C1* expr_2_;
+  };
+  
+  D1::D1(C1 *expr_1, C1 *expr_2)
+    : expr_1_(expr_1), expr_2_(expr_2) { }
+
+  C1 *create1() {
+    return new D1(0, 0);
+  }
+
+} // n1
+
+int main()
+{
+    using namespace n1;
+    using namespace n2;
+
+    C1 *e1 = create1();
+    C2 *e2 = create2();
+
+    return 0;				// constructs-done
+}
--- /dev/null	2002-08-30 16:31:37.000000000 -0700
+++ testsuite/gdb.c++/rtti2.cc	2003-05-02 10:42:07.000000000 -0700
@@ -0,0 +1,36 @@
+/* Code to go along with tests in rtti.exp.
+   
+   Copyright 2003 Free Software Foundation, Inc.
+
+   Contributed by David Carlton <carlton@bactrian.org> and by Kealia,
+   Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or (at
+   your option) any later version.
+
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+#include "rtti.h"
+
+namespace n2 {
+  
+  D2::D2(C2 *expr_1, C2 *expr_2)
+    : expr_1_(expr_1), expr_2_(expr_2) { }
+
+  C2 *create2() {
+    return new D2(0, 0);
+  }
+
+}
--- /dev/null	2002-08-30 16:31:37.000000000 -0700
+++ testsuite/gdb.c++/rtti.h	2003-05-02 10:39:02.000000000 -0700
@@ -0,0 +1,48 @@
+/* Code to go along with tests in rtti.exp.
+   
+   Copyright 2003 Free Software Foundation, Inc.
+
+   Contributed by David Carlton <carlton@bactrian.org> and by Kealia,
+   Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or (at
+   your option) any later version.
+
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  */
+
+namespace n2 {
+
+  class C2;
+
+  class Base2 {
+  public:
+    virtual ~Base2() { }
+  };
+
+
+  class C2: public Base2 {
+  public:
+  };
+
+  class D2 : public C2{
+  public:
+    D2(C2 *, C2 *);
+    
+    C2* expr_1_;
+    C2* expr_2_;
+  };
+
+  extern C2 *create2();
+}
Index: config/djgpp/fnchange.lst
===================================================================
RCS file: /cvs/src/src/gdb/config/djgpp/fnchange.lst,v
retrieving revision 1.34.2.6
diff -u -p -r1.34.2.6 fnchange.lst
--- config/djgpp/fnchange.lst	1 May 2003 00:46:54 -0000	1.34.2.6
+++ config/djgpp/fnchange.lst	2 May 2003 17:52:01 -0000
@@ -261,6 +261,10 @@
 @V@/gdb/testsuite/gdb.c++/psmang2.cc @V@/gdb/testsuite/gdb.cxx/psmang2.cc
 @V@/gdb/testsuite/gdb.c++/ref-types.cc @V@/gdb/testsuite/gdb.cxx/ref-types.cc
 @V@/gdb/testsuite/gdb.c++/ref-types.exp @V@/gdb/testsuite/gdb.cxx/ref-types.exp
+@V@/gdb/testsuite/gdb.c++/rtti1.cc @V@/gdb/testsuite/gdb.cxx/rtti1.cc
+@V@/gdb/testsuite/gdb.c++/rtti2.cc @V@/gdb/testsuite/gdb.cxx/rtti2.cc
+@V@/gdb/testsuite/gdb.c++/rtti.h @V@/gdb/testsuite/gdb.cxx/rtti.h
+@V@/gdb/testsuite/gdb.c++/rtti.exp @V@/gdb/testsuite/gdb.cxx/rtti.exp
 @V@/gdb/testsuite/gdb.c++/templates.cc @V@/gdb/testsuite/gdb.cxx/templates.cc
 @V@/gdb/testsuite/gdb.c++/templates.exp @V@/gdb/testsuite/gdb.cxx/templates.exp
 @V@/gdb/testsuite/gdb.c++/try_catch.cc @V@/gdb/testsuite/gdb.cxx/try_catch.cc


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]