This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [offbyone RFC] Merge i386newframe
- From: Mark Kettenis <kettenis at chello dot nl>
- To: mludvig at suse dot cz
- Cc: gdb-patches at sources dot redhat dot com, ac131313 at redhat dot com
- Date: Sun, 16 Mar 2003 13:48:17 +0100 (CET)
- Subject: Re: [offbyone RFC] Merge i386newframe
- References: <3E6FAF64.7070304@suse.cz> <3E71F890.7090304@suse.cz>
Date: Fri, 14 Mar 2003 16:43:12 +0100
From: Michal Ludvig <mludvig at suse dot cz>
Hi all,
I've reworked the merge a little to avoid the need to reorder
frame.c:get_prev_frame() and fixed the 'next' and 'return' bugs that
were in the prevoius one. Now it passes the testsuite even better than
the i386newframe code did :-)
I'm sorry I'm short of time to write more now.
Andrew and Mark, please look around the patch and tell me your opinions.
Michal,
I appreciate your efforts here, but your patch introduces
Linux-specific code into i386-tdep.c. I'm sorry, but we can't have
that. I'll try to keep my i386newframe branch synced with HEAD. I'm
afraid I don't have the time now to keep track of the offbyone branch
right now, but as Andrew merges things from there, I'll pick them up
in i386newframe. I'll certainly take a look at your patch, and
incorporate the good bits.
Mark