Re: [RFA] Prologue detection on x86-64

[Michal Ludvig <mludvig at suse dot cz>]

Daniel Jacobowitz wrote:
> On Fri, Mar 07, 2003 at 12:14:55AM +0100, Michal Ludvig wrote:
>
> > Daniel Jacobowitz wrote:
> >
> > > On Thu, Mar 06, 2003 at 11:56:44PM +0100, Michal Ludvig wrote:
> > >
> > > > +/* We will handle only functions beginning with:
> > > > +   55          pushq %rbp
> > > > +   48 89 e5    movq %rsp,%rbp */
> > >
> > > Period and two spaces, please.
> >
> > Period after %rbp? It wouldn't be an assembler anymore :-(
> > How about two spaces and no period instead? (compromise :-)
>
> What I usually do in this case is make up a sentence to go before the
> period :P  No joking.  Something like:
> /* We will handle only functions beginning with
>    55         pushq %rbp
>    48 89 e5   movq %rsp, %rbp
>    Any function that doesn't start with this sequence
>    will be assumed to have no prologue.  */

OK, committed with this change and removed 'static' keyword.

Michal Ludvig
--
* SuSE CR, s.r.o     * mludvig at suse dot cz
* (+420) 296.545.373 * http://www.suse.cz