This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC]: win32-nat.c better handling of DLL relocation
- From: Christopher Faylor <cgf at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 11 Jan 2003 12:24:31 -0500
- Subject: Re: [RFC]: win32-nat.c better handling of DLL relocation
- References: <avpefr$mp5$1@main.gmane.org>
- Reply-to: gdb-patches at sources dot redhat dot com
On Sat, Jan 11, 2003 at 03:52:09PM -0000, Raoul Gough wrote:
>win32-nat.c currently only passes the loaded address of the .text
>section into symbol_file_add, which means that any symbols from .data
>or .bss don't get fixed up properly. This patch fixes the problem by
>calculating the load addresses of all sections known to bfd.
>
>I recently posted a test case which demonstrates the relocation
>problem in the "coffread.c extension" thread (message ID
>avejk1$lv6$1@main.gmane.org, posted 7 Jan 2003 13:10:49 -0000). This
>showed that gdb 5.2.1 didn't handle any DLL symbol relocations. The
>current CVS version only handles the .text section. With this patch,
>it handles all sections correctly.
>
>Raoul Gough.
>2003-01-10 Raoul Gough <RaoulGough@yahoo.co.uk>
>
> * win32-nat.c(get_relocated_section_addrs): New function. Find
> section load addresses for symbol handling in relocated DLLs.
> (solib_symbols_add): Open a bfd and call get_relocated_section_addrs.
I took a quick glance. Looks good. Now we just need that pesky
assignment.
<idle musing>I wonder if there is some way to do all of this assignment stuff
electronically. It seems silly that we still have to rely on paper for this
kind of thing.</idle musing>
cgf