This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Use methods to manipulate frame->next / ->prev


Hello,

As the comment notes:

+/* FIXME: cagney/2003-01-07: These are just nasty.  Code shouldn't be
+   doing this.  I suspect it dates back to the days when every field
+   of an allocated structure was explicitly initialized.  */

commited,
Andrew
2003-01-07  Andrew Cagney  <cagney@redhat.com>

	* frame.c (deprecated_set_frame_next_hack): New function.
	(deprecated_set_frame_prev_hack): New function.
	* frame.h (deprecated_set_frame_next_hack): Declare.
	(deprecated_set_frame_prev_hack): Declare.
	* mcore-tdep.c (analyze_dummy_frame): Use
	deprecated_set_frame_next_hack and deprecated_set_frame_prev_hack.
	* mn10300-tdep.c (analyze_dummy_frame): Ditto.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.53
diff -u -r1.53 frame.c
--- frame.c	7 Jan 2003 16:29:22 -0000	1.53
+++ frame.c	7 Jan 2003 19:16:19 -0000
@@ -1308,6 +1308,20 @@
   frame->extra_info = extra_info;
 }
 
+void
+deprecated_set_frame_next_hack (struct frame_info *fi,
+				struct frame_info *next)
+{
+  fi->next = next;
+}
+
+void
+deprecated_set_frame_prev_hack (struct frame_info *fi,
+				struct frame_info *prev)
+{
+  fi->prev = prev;
+}
+
 struct frame_info *
 deprecated_frame_xmalloc (void)
 {
Index: frame.h
===================================================================
RCS file: /cvs/src/src/gdb/frame.h,v
retrieving revision 1.56
diff -u -r1.56 frame.h
--- frame.h	6 Jan 2003 21:50:25 -0000	1.56
+++ frame.h	7 Jan 2003 19:16:20 -0000
@@ -693,4 +693,12 @@
 extern struct frame_info *deprecated_frame_xmalloc_with_cleanup (long sizeof_saved_regs,
 								 long sizeof_extra_info);
 
+/* FIXME: cagney/2003-01-07: These are just nasty.  Code shouldn't be
+   doing this.  I suspect it dates back to the days when every field
+   of an allocated structure was explicitly initialized.  */
+extern void deprecated_set_frame_next_hack (struct frame_info *fi,
+					    struct frame_info *next);
+extern void deprecated_set_frame_prev_hack (struct frame_info *fi,
+					    struct frame_info *prev);
+
 #endif /* !defined (FRAME_H)  */
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.33
diff -u -r1.33 mcore-tdep.c
--- mcore-tdep.c	7 Jan 2003 14:51:10 -0000	1.33
+++ mcore-tdep.c	7 Jan 2003 19:16:20 -0000
@@ -296,8 +296,8 @@
       deprecated_set_frame_extra_info_hack (dummy, extra_info);
     }
 
-  dummy->next = NULL;
-  dummy->prev = NULL;
+  deprecated_set_frame_next_hack (dummy, NULL);
+  deprecated_set_frame_prev_hack (dummy, NULL);
   deprecated_update_frame_pc_hack (dummy, pc);
   deprecated_update_frame_base_hack (dummy, frame);
   dummy->extra_info->status = 0;
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.47
diff -u -r1.47 mn10300-tdep.c
--- mn10300-tdep.c	7 Jan 2003 16:22:29 -0000	1.47
+++ mn10300-tdep.c	7 Jan 2003 19:16:21 -0000
@@ -159,8 +159,8 @@
       extra_info = XMALLOC (struct frame_extra_info);
       deprecated_set_frame_extra_info_hack (dummy, extra_info);
     }
-  dummy->next = NULL;
-  dummy->prev = NULL;
+  deprecated_set_frame_next_hack (dummy, NULL);
+  deprecated_set_frame_prev_hack (dummy, NULL);
   deprecated_update_frame_pc_hack (dummy, pc);
   deprecated_update_frame_base_hack (dummy, frame);
   dummy->extra_info->status = 0;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]