This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
RFC: print better messages for separate debug info
- From: Jim Blandy <jimb at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: 23 Dec 2002 04:39:27 -0500
- Subject: RFC: print better messages for separate debug info
2002-12-23 Jim Blandy <jimb@redhat.com>
* symfile.c (syms_from_objfile): Don't print the "(no debugging
symbols found)" message here; we haven't checked for a separate
debug info file yet, so we don't know yet.
(symbol_file_add_with_addrs_or_offsets): Print it here, after
we've looked everywhere. Also, there's no need to print a special
message when we're loading the separate debug info file: the one
symbol_file_add prints is fine.
Index: gdb/symfile.c
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.75.2.3
diff -c -r1.75.2.3 symfile.c
*** gdb/symfile.c 23 Dec 2002 09:22:59 -0000 1.75.2.3
--- gdb/symfile.c 23 Dec 2002 09:52:14 -0000
***************
*** 808,820 ****
(*objfile->sf->sym_read) (objfile, mainline);
- if (!have_partial_symbols () && !have_full_symbols ())
- {
- wrap_here ("");
- printf_filtered ("(no debugging symbols found)...");
- wrap_here ("");
- }
-
/* Don't allow char * to have a typename (else would get caddr_t).
Ditto void *. FIXME: Check whether this is now done by all the
symbol readers themselves (many of them now do), and if so remove
--- 808,813 ----
***************
*** 976,989 ****
debugfile = find_separate_debug_file (objfile);
if (debugfile)
{
- if (from_tty || info_verbose)
- {
- printf_filtered ("loading separate debug info from '%s'",
- debugfile);
- wrap_here ("");
- gdb_flush (gdb_stdout);
- }
-
if (addrs != NULL)
{
objfile->separate_debug_objfile
--- 969,974 ----
***************
*** 1004,1009 ****
--- 989,1001 ----
xfree (debugfile);
}
+ if (!have_partial_symbols () && !have_full_symbols ())
+ {
+ wrap_here ("");
+ printf_filtered ("(no debugging symbols found)...");
+ wrap_here ("");
+ }
+
if (from_tty || info_verbose)
{
if (post_add_symbol_hook)