This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] New method find_frame_sal()
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 1 Dec 2002 07:59:07 +0200 (IST)
- Subject: Re: [commit] New method find_frame_sal()
On Thu, 28 Nov 2002, Andrew Cagney wrote:
> While cleaning up accesses to the `struct frame_info', I kept coming
> across code snippits like:
>
> sal = find_pc_line (fi->pc,
> (fi->next != (struct frame_info *) NULL
> && !(get_frame_type (fi->next) == SIGTRAMP_FRAME)
> && !(get_frame_type (fi->next) == DUMMY_FRAME)));
>
> (Originally it was worse, as there was also fi->signal_handler_caller
> and PC_IN_CALL_DUMMY (fi->pc, fi->frame, fi->frame).)
>
> The attached patch adds the function:
>
> find_frame_sal(fi, &sal);
>
> that encapsulates all of the above.
Should this method be documented in gdbint.texinfo perhaps?