This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commited] Flush arm and mips of old non-generic dummy-frame code
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 23 Nov 2002 12:20:25 -0500
- Subject: [commited] Flush arm and mips of old non-generic dummy-frame code
I think the ARM and MIPS have been converted to generic dummy frames for
a long enough period of time to no longer need the old hooks.
This patch removes the old dead code.
committed as obvious,
Andrew
2002-11-23 Andrew Cagney <ac131313@redhat.com>
* arm-tdep.c (arm_gdbarch_init): Remove old style non-generic
dummy frame initialization code.
* mips-tdep.c (mips_gdbarch_init): Ditto.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.76
diff -u -r1.76 arm-tdep.c
--- arm-tdep.c 18 Nov 2002 22:19:26 -0000 1.76
+++ arm-tdep.c 23 Nov 2002 16:56:49 -0000
@@ -2819,31 +2819,6 @@
tdep->lowest_pc = 0x20;
tdep->jb_pc = -1; /* Longjump support not enabled by default. */
-#if OLD_STYLE_ARM_DUMMY_FRAMES
- /* NOTE: cagney/2002-05-07: Enable the below to restore the old ARM
- specific (non-generic) dummy frame code. Might be useful if
- there appears to be a problem with the generic dummy frame
- mechanism that replaced it. */
- set_gdbarch_use_generic_dummy_frames (gdbarch, 0);
-
- /* Call dummy code. */
- set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
- set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 1);
- /* We have to give this a value now, even though we will re-set it
- during each call to arm_fix_call_dummy. */
- set_gdbarch_call_dummy_breakpoint_offset (gdbarch, 8);
- set_gdbarch_call_dummy_p (gdbarch, 1);
- set_gdbarch_call_dummy_stack_adjust_p (gdbarch, 0);
-
- set_gdbarch_call_dummy_words (gdbarch, arm_call_dummy_words);
- set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof (arm_call_dummy_words));
- set_gdbarch_call_dummy_start_offset (gdbarch, 0);
- set_gdbarch_call_dummy_length (gdbarch, 0);
-
- set_gdbarch_fix_call_dummy (gdbarch, arm_fix_call_dummy);
-
- set_gdbarch_pc_in_call_dummy (gdbarch, pc_in_call_dummy_on_stack);
-#else
set_gdbarch_use_generic_dummy_frames (gdbarch, 1);
set_gdbarch_call_dummy_location (gdbarch, AT_ENTRY_POINT);
@@ -2863,7 +2838,6 @@
set_gdbarch_call_dummy_address (gdbarch, entry_point_address);
set_gdbarch_push_return_address (gdbarch, arm_push_return_address);
-#endif
set_gdbarch_get_saved_register (gdbarch, deprecated_generic_get_saved_register);
set_gdbarch_push_arguments (gdbarch, arm_push_arguments);
@@ -2883,15 +2857,7 @@
set_gdbarch_frame_num_args (gdbarch, arm_frame_num_args);
set_gdbarch_frame_args_skip (gdbarch, 0);
set_gdbarch_frame_init_saved_regs (gdbarch, arm_frame_init_saved_regs);
-#if OLD_STYLE_ARM_DUMMY_FRAMES
- /* NOTE: cagney/2002-05-07: Enable the below to restore the old ARM
- specific (non-generic) dummy frame code. Might be useful if
- there appears to be a problem with the generic dummy frame
- mechanism that replaced it. */
- set_gdbarch_push_dummy_frame (gdbarch, arm_push_dummy_frame);
-#else
set_gdbarch_push_dummy_frame (gdbarch, generic_push_dummy_frame);
-#endif
set_gdbarch_pop_frame (gdbarch, arm_pop_frame);
/* Address manipulation. */
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.136
diff -u -r1.136 mips-tdep.c
--- mips-tdep.c 23 Nov 2002 01:39:25 -0000 1.136
+++ mips-tdep.c 23 Nov 2002 16:56:53 -0000
@@ -5990,38 +5990,23 @@
set_gdbarch_call_dummy_p (gdbarch, 1);
set_gdbarch_call_dummy_stack_adjust_p (gdbarch, 0);
-#if OLD_STYLE_MIPS_DUMMY_FRAMES
- set_gdbarch_use_generic_dummy_frames (gdbarch, 0);
-#else
set_gdbarch_use_generic_dummy_frames (gdbarch, 1);
-#endif
set_gdbarch_call_dummy_location (gdbarch, AT_ENTRY_POINT);
set_gdbarch_call_dummy_address (gdbarch, mips_call_dummy_address);
set_gdbarch_push_return_address (gdbarch, mips_push_return_address);
-#if OLD_STYLE_MIPS_DUMMY_FRAMES
- set_gdbarch_push_dummy_frame (gdbarch, mips_push_dummy_frame);
-#else
set_gdbarch_push_dummy_frame (gdbarch, generic_push_dummy_frame);
-#endif
set_gdbarch_pop_frame (gdbarch, mips_pop_frame);
set_gdbarch_call_dummy_start_offset (gdbarch, 0);
set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 1);
set_gdbarch_call_dummy_breakpoint_offset (gdbarch, 0);
set_gdbarch_call_dummy_length (gdbarch, 0);
set_gdbarch_fix_call_dummy (gdbarch, mips_fix_call_dummy);
-#if OLD_STYLE_MIPS_DUMMY_FRAMES
- set_gdbarch_pc_in_call_dummy (gdbarch, pc_in_call_dummy_at_entry_point);
-#else
set_gdbarch_pc_in_call_dummy (gdbarch, generic_pc_in_call_dummy);
-#endif
set_gdbarch_call_dummy_words (gdbarch, mips_call_dummy_words);
set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof (mips_call_dummy_words));
set_gdbarch_push_return_address (gdbarch, mips_push_return_address);
set_gdbarch_frame_align (gdbarch, mips_frame_align);
-#if OLD_STYLE_MIPS_DUMMY_FRAMES
-#else
set_gdbarch_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
-#endif
set_gdbarch_register_convertible (gdbarch, mips_register_convertible);
set_gdbarch_register_convert_to_virtual (gdbarch,
mips_register_convert_to_virtual);