This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/testsuite] Don't display values in output of pc-fp.exp
- From: David Carlton <carlton at math dot stanford dot edu>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, Fernando Nasser <fnasser at redhat dot com>, cagney <cagney at redhat dot com>
- Date: 05 Nov 2002 15:11:16 -0800
- Subject: Re: [rfa/testsuite] Don't display values in output of pc-fp.exp
- References: <ro1u1ivacl5.fsf@jackfruit.Stanford.EDU><3DC84C23.8070801@redhat.com>
On Tue, 05 Nov 2002 17:54:27 -0500, Andrew Cagney <ac131313@redhat.com> said:
>> The tests in pc-fp.exp display the actual values of $pc and $fp in
>> their PASS messages. That makes regression testing a bit more
>> annoying for me: the value of $fp changes with every change I make
>> to GDB. Is it okay to tweak the PASS messages not to display those
>> values?
> As far as I know, anything in trailing paren should be ignored when
> comparing test results. You might want to tweak your script (I've
> attached mine) to do this.
Wow: your script is complicated. I just do
diff -u (first file) (second file) | grep -v schedlock
I could do something more complicated than that, of course; on the
other hand, I'm still not convinced that I should. It seems to me
that details like the value of the variables in question shouldn't be
in gdb.sum: if I want that level of information, I'll look in gdb.log.
I think there's a virtue in having gdb.sum in a format that's easily
checkable without worrying about parsing issues: the easier it is to
do regression testing, the more often it will happen.
> Also, why is FP/PC changing? Your GDB changes shouldn't affect the
> behavior of the target program's $fp / $pc.
That's a good point; I hadn't thought of that. I'm actually not
entirely sure what it is that leads to the value of $fp changing from
test run to test run. But I will make the empirical observation that
it does change from test run to test run, and I'd be shocked if those
changes reflected introduction of new bugs into GDB.
David Carlton
carlton@math.stanford.edu