Re: [patch] some mindless additions of BLOCK_ macros

[Andrew Cagney <ac131313 at redhat dot com>]

> I recently noticed that the BLOCK_ macros weren't used everywhere they
> could be.  I know Andrew doesn't like macros, but given that these
> ones are used almost everywhere, they might as well be used
> everywhere.
Yep.

It's more that I like opaque types - it is all about `control' - with an 
opaque type it simply isn't possible to sneak in [old] code that grubs 
around in the internals.  You could consider block.[hc]?

(I need to come clean and admit that I'm quietly moving all the frame 
specific stuff out of blockframe.c and into frame.c so it can be opaque. 
 I suspect everone guessed this long ago, though :-)

> I've tested the parse.c part of this by doing a make check, the
> x86-64-tdep.c part by doing an all targets build and noticing that it
> still compiles, and the objc-lang.c part hasn't been tested at all.
> They're all trivial changes, so that amount of testing seems to me to
> be sufficient.
>
> This patch seems obvious to me; if nobody complains, I'll commit it in
> a day or two.
I think its safe for today.

Andrew