Re: [PATCH] Objective-C language support.

[Michael Snyder <msnyder at redhat dot com>]

Adam Fedor wrote:
> 
> Michael Snyder wrote:
> > Adam, this is approved, but do you think you could make
> > the comment a little more informative?  And Capitolize "Also"
> > and add a period.
> >
> >
> >
> >>        * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method
> >>        names when checking default.
> 
> This is my minor improvement. Ok?

Yes, approved.

> 
> 2002-10-14  Adam Fedor  <fedor@gnu.org>
> 
>         * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method
>         names when matching breakpoints in current file.
> 
> --
> Adam Fedor, Digital Optics Corp.      | I'm glad I hate spinach, because
> http://www.doc.com                    | if I didn't, I'd eat it, and you
>                                        | know how I hate the stuff.
> 
>   -------------------------------------------------------------------------------
> Index: breakpoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.90
> diff -u -p -r1.90 breakpoint.c
> --- breakpoint.c        22 Sep 2002 20:29:52 -0000      1.90
> +++ breakpoint.c        15 Oct 2002 02:31:48 -0000
> @@ -4618,13 +4618,16 @@ parse_breakpoint_sals (char **address,
>        /* Force almost all breakpoints to be in terms of the
>           current_source_symtab (which is decode_line_1's default).  This
>           should produce the results we want almost all of the time while
> -         leaving default_breakpoint_* alone.  */
> +         leaving default_breakpoint_* alone.
> +         ObjC: However, don't match an Objective-C method name which
> +         may have a '+' or '-' succeeded by a '[' */
> 
>        struct symtab_and_line cursal = get_current_source_symtab_and_line ();
> 
>        if (default_breakpoint_valid
>           && (!cursal.symtab
> -             || (strchr ("+-", (*address)[0]) != NULL)))
> +             || ((strchr ("+-", (*address)[0]) != NULL)
> +                 && ((*address)[1] != '['))))
>         *sals = decode_line_1 (address, 1, default_breakpoint_symtab,
>                                default_breakpoint_line, addr_string);
>        else